Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default compression argument for JsonDatasetWriter #6659

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Change default compression argument for JsonDatasetWriter #6659

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f41dff2
Change default compression argument for JsonDatasetWriter
Rexhaif Feb 11, 2024
6ef1eab
Fix incorrect default json compression when writing to buffer
Rexhaif Feb 12, 2024
efde328
fix empty space
Rexhaif Feb 13, 2024
757e2f6
Merge branch 'main' into patch-1
lhoestq Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/datasets/io/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ def write(self) -> int:
lines = self.to_json_kwargs.pop("lines", True if orient == "records" else False)
if "index" not in self.to_json_kwargs and orient in ["split", "table"]:
self.to_json_kwargs["index"] = False
compression = self.to_json_kwargs.pop("compression", None)

# Determine the default compression value based on self.path_or_buf type
default_compression = "infer" if isinstance(self.path_or_buf, (str, bytes, os.PathLike)) else None
compression = self.to_json_kwargs.pop("compression", default_compression)

if compression not in [None, "infer", "gzip", "bz2", "xz"]:
raise NotImplementedError(f"`datasets` currently does not support {compression} compression")
Expand Down
Loading