-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Pillow >= 9.4.0 to avoid AttributeError when loading image dataset #6883
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Do you think this is worth making a patch release for? |
Show benchmarksPyArrow==8.0.0 Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
|
maybe not super important since it was not reported by users, this can be included in the next release |
I observed the same AttributeError with Pillow == 10.3.0, while 9.4.0 works for me. |
What's the error you're getting @Eric2i ? On my side on 10.3.0 I could run this without errors: import PIL.Image
PIL.Image.ExifTags.Base.Orientation is not None # True |
Sorry, false alarm. I double-checked that 10.3.0 is also good on my side. Thanks for your sample codes. |
…taset (#6883) Pin Pillow required min version
…taset (#6883) Pin Pillow required min version
I just faced the same bug after installing recent versions of Huggingface and datasets in a new environment. I solved it by uninstalling the recent version of Pillow and sticking to 9.4.0. |
Thanks! That error was annoying and this fixed it for me. |
Just to say I also bumped into this and this issue was very helpful for finding the right pillow version. Thanks. |
Require Pillow >= 9.4.0 to avoid AttributeError when loading image dataset.
The
PIL.Image.ExifTags
that we use in our code was implemented in Pillow-9.4.0: python-pillow/Pillow@24a5405The bug #6881 was introduced in datasets-2.19.0 by this PR:
Fix #6881.