Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HacktoberFest][Missing Docstrings] Würstchen #5241

Closed
stevhliu opened this issue Sep 29, 2023 · 1 comment
Closed

[HacktoberFest][Missing Docstrings] Würstchen #5241

stevhliu opened this issue Sep 29, 2023 · 1 comment
Labels
hacktoberfest

Comments

@stevhliu
Copy link
Member

This feature request is included in this year's Diffusers Hacktoberfest 🎃!

Hacktoberfest's purpose is to give upcoming open-source developers the opportunity to learn about open-source and programming by fixing simple issues (like this one).

How to solve the issue:

    1. Every issue has a description further below explaining the problem. First, you should try to understand the issue.
    1. Second, follow the contribution guide to learn how to contribute to Diffusers.\
    1. Claim this issue for you by opening a PR that links to this issue and writing, "I am solving this issue in <link-to-pr>".

Issue

The Würstchen API docs are a bit out of sync. For example:

  • prior_num_inference_steps=60 in WuerstchenCombinedPipeline.__call__ but the docstring says it defaults to 30.
  • The WuerstchenPriorPipeline is missing some arguments like latent_mean, latent_std, and resolution_multiple. The height, width, num_inference_steps, and guidance_scale in the __call__ are also out of sync.
  • The WuerstchenDecoderPipeline also has the same issues in the __call__ function where some of the parameters are not aligned with what's in the function signature.
@jgyfutub jgyfutub mentioned this issue Sep 29, 2023
Closed
@jgyfutub
Copy link
Contributor

I am solving this issue

@jgyfutub jgyfutub mentioned this issue Oct 1, 2023
Merged
stevhliu pushed a commit that referenced this issue Oct 6, 2023
@jgyfutub @kashif
[Hacktoberfest]Fixing issues #5241 (#5255)
dd25ef5 
* Update pipeline_wuerstchen_prior.py

* prior_num_inference_steps updated

* height, width, num_inference_steps, and guidance_scale synced

* parameters synced

* latent_mean, latent_std, and resolution_multiple synced

* prior_num_inference_steps changed

* Formatted pipeline_wuerstchen_prior.py

* Update src/diffusers/pipelines/wuerstchen/pipeline_wuerstchen_prior.py

---------

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
@stevhliu stevhliu closed this as completed Oct 6, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this issue Dec 25, 2023
@jgyfutub @kashif
[Hacktoberfest]Fixing issues huggingface#5241 (huggingface#5255)
3c56590 
* Update pipeline_wuerstchen_prior.py

* prior_num_inference_steps updated

* height, width, num_inference_steps, and guidance_scale synced

* parameters synced

* latent_mean, latent_std, and resolution_multiple synced

* prior_num_inference_steps changed

* Formatted pipeline_wuerstchen_prior.py

* Update src/diffusers/pipelines/wuerstchen/pipeline_wuerstchen_prior.py

---------

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this issue Apr 26, 2024
@jgyfutub @kashif
[Hacktoberfest]Fixing issues huggingface#5241 (huggingface#5255)
ee5d187 
* Update pipeline_wuerstchen_prior.py

* prior_num_inference_steps updated

* height, width, num_inference_steps, and guidance_scale synced

* parameters synced

* latent_mean, latent_std, and resolution_multiple synced

* prior_num_inference_steps changed

* Formatted pipeline_wuerstchen_prior.py

* Update src/diffusers/pipelines/wuerstchen/pipeline_wuerstchen_prior.py

---------

Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevhliu @jgyfutub