[tests] make tests device-agnostic (part 4) #10508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
|
Hi @sayakpaul @hlky @DN6 , could we proceed with this PR? Thx a lot! |
sayakpaul
reviewed
Feb 7, 2025
| @@ -101,7 +102,7 @@ def tearDown(self): | |||
| # Keeping this test here makes sense because it doesn't look any integration | |||
| # (value assertions on logits). | |||
| @slow | |||
| @require_torch_gpu | |||
| @require_torch_accelerator | |||
There was a problem hiding this comment.
Do we need to condition the assertion slices based on the accelerator being used?
There was a problem hiding this comment.
Yes, we might need to do so. But I plan to submit a follow-up PR for value assertion related issues. Because we need to investigate whether this is not a bug in our own software stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up of PR #10437