type hints: models/vae.py #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
src/diffusers/models/vae.py
Outdated
| @@ -293,7 +293,7 @@ def __init__(self, parameters, deterministic=False): | |||
| if self.deterministic: | |||
| self.var = self.std = torch.zeros_like(self.mean).to(device=self.parameters.device) | |||
|
|
|||
| def sample(self, generator=None): | |||
| def sample(self, generator=None) -> torch.Tensor: | |||
There was a problem hiding this comment.
Suggested change
| def sample(self, generator=None) -> torch.Tensor: | |
| def sample(self, generator: Optional[torch.Generator] = None) -> torch.FloatTensor: |
src/diffusers/models/vae.py
Outdated
| h = self.encoder(x) | ||
| moments = self.quant_conv(h) | ||
| posterior = DiagonalGaussianDistribution(moments) | ||
| return posterior | ||
|
|
||
| def decode(self, z): | ||
| def decode(self, z: torch.Tensor) -> torch.FloatTensor: |
There was a problem hiding this comment.
Suggested change
| def decode(self, z: torch.Tensor) -> torch.FloatTensor: | |
| def decode(self, z: torch.FloatTensor) -> torch.FloatTensor: |
src/diffusers/models/vae.py
Outdated
| z = self.post_quant_conv(z) | ||
| dec = self.decoder(z) | ||
| return dec | ||
|
|
||
| def forward(self, sample, sample_posterior=False): | ||
| def forward(self, sample: torch.FloatTensor, sample_posterior=False): |
There was a problem hiding this comment.
Suggested change
| def forward(self, sample: torch.FloatTensor, sample_posterior=False): | |
| def forward(self, sample: torch.FloatTensor, sample_posterior: bool = False) -> torch.FloatTensor: |
|
@patrickvonplaten Thank you for the review. I have made the changes based on your suggestions. Thanks |
patrickvonplaten
approved these changes
Sep 4, 2022
|
A small merge conflict with recent updates from |
natolambert
pushed a commit
that referenced
this pull request
Sep 7, 2022
* type hints: models/vae.py * modify typings in vae.py Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Anton Lozhkov <anton@huggingface.co>
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* type hints: models/vae.py * modify typings in vae.py Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Anton Lozhkov <anton@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added type hints for 5 and 6 from #287
@pcuenca I'll be glad if you can check it out.