Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a docstring for the AutoencoderKL's encode #5239

Conversation

freespirit
Copy link
Contributor

Fixes #5229

@freespirit
Copy link
Contributor Author

I tried to reuse as much as possible the style and contents of the tiled_encode docstring

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me ❤️

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need the tests to pass here. Could you please run make style && make quality?

@freespirit
Copy link
Contributor Author

Ran make style & make quality. Thank you all for the support!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@patrickvonplaten
Copy link
Contributor

Failing tests are unrelated - merging!

@patrickvonplaten patrickvonplaten merged commit 7a4324c into huggingface:main Oct 2, 2023
10 of 11 checks passed
@freespirit freespirit deleted the autoencoderkl_encode_docstring_5229 branch October 2, 2023 18:29
rchuzh99 pushed a commit to rchuzh99/diffusers that referenced this pull request Oct 4, 2023
* Add docstring for the AutoencoderKL's encode

huggingface#5229

* Support Python 3.8 syntax in AutoencoderKL.decode type hints

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

* Follow the style guidelines in AutoencoderKL's encode

huggingface#5230

---------

Co-authored-by: stano <>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Add docstring for the AutoencoderKL's encode

huggingface#5229

* Support Python 3.8 syntax in AutoencoderKL.decode type hints

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

* Follow the style guidelines in AutoencoderKL's encode

huggingface#5230

---------

Co-authored-by: stano <>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Add docstring for the AutoencoderKL's encode

huggingface#5229

* Support Python 3.8 syntax in AutoencoderKL.decode type hints

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

* Follow the style guidelines in AutoencoderKL's encode

huggingface#5230

---------

Co-authored-by: stano <>
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HacktoberFest][Missing Docstrings] Autoencoder encode
4 participants