-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I Added Doc-String Into The class. #5293
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8425cd4
I added a new doc string to the class. This is more flexible to under…
hi-sushanta 8a0e77d
Merge branch 'main' into doc_string
hi-sushanta cf3a816
Merge branch 'main' into doc_string
hi-sushanta a0cd96f
Merge branch 'main' into doc_string
hi-sushanta 746a8e8
Update src/diffusers/models/unet_2d_blocks.py
hi-sushanta 6e56886
Update src/diffusers/models/unet_2d_blocks.py
hi-sushanta 627fd9f
Update unet_2d_blocks.py
hi-sushanta ae4f7f2
Update unet_2d_blocks.py
hi-sushanta f0bea43
Update unet_2d_blocks.py
hi-sushanta 872a4a5
Merge branch 'main' into doc_string
hi-sushanta 3546f6d
I run the black command to reformat style in the code
hi-sushanta 12534f4
Merge branch 'main' into doc_string
hi-sushanta 48afb4b
Merge branch 'main' into doc_string
hi-sushanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation seems to be off. Could we fix that? It should be:
The structure of the API documentation is referred from https://github.com/huggingface/doc-builder#writing-source-documentation.
The supported activation functions can be noted from:
diffusers/src/diffusers/models/activations.py
Line 4 in 0513a8c
Let me know if there's anything unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have solved the indentation problem. The get_activation function is defined in a separate file, so I will not explain it here 🤗.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not about explaining that. It's about including the right information. The current statement suggests that we support
tanh
andsigmoid
as the activation values but we clearly not (as evident in theget_activation()
function). To make that point clearly, I provided the reference toget_activation()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry, that was my mistake.