fix une2td ignoring class_labels #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
DN6
reviewed
Oct 17, 2023
src/diffusers/models/unet_2d.py
Outdated
| @@ -291,7 +291,9 @@ def forward( | |||
|
|
|||
| class_emb = self.class_embedding(class_labels).to(dtype=self.dtype) | |||
| emb = emb + class_emb | |||
|
|
|||
| elif self.class_embedding is None and class_labels is not None: | |||
| raise ValueError("class_embedding needs to be initialized to use class conditioning") | |||
There was a problem hiding this comment.
Suggested change
| raise ValueError("class_embedding needs to be initialized to use class conditioning") | |
| raise ValueError("class_embedding needs to be initialized in order to use class conditioning") |
|
Hi @kesimeg Could you please run |
mhetrerajat
pushed a commit
to mhetrerajat/diffusers
that referenced
this pull request
Oct 23, 2023
* fix une2td ignoring class_labels * unet2.py error message updated * style and quality changes --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* fix une2td ignoring class_labels * unet2.py error message updated * style and quality changes --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* fix une2td ignoring class_labels * unet2.py error message updated * style and quality changes --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
UNet2DModel ignores class_labels parameter when class_embedding is not initialized and does not give any error. This causes users to give pass a parameter that does not change anything. I changed the code so that it gives error and user becomes aware that they have to initialize class_embeddings. I opened an issue about this before: #5330
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.