[PEFT / Tests] Add peft slow tests on push
#5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
commented
Oct 17, 2023
|
@DN6 can you check here? |
|
@DN6 gentle ping. |
sayakpaul
reviewed
Oct 25, 2023
| python -m pytest -n 1 --max-worker-restart=0 --dist=loadfile \ | ||
| -s -v -k "not Flax and not Onnx" \ | ||
| --make-reports=tests_peft_cuda \ | ||
| tests/lora/ |
There was a problem hiding this comment.
Under lora we have the test suite that doesn't utilize peft. Do we wanna include them here?
There was a problem hiding this comment.
Yes but they're going to be skipped thanks to this decorator: https://github.com/huggingface/diffusers/blob/main/tests/lora/test_lora_layers_old_backend.py#L1883 being set everywhere
|
Reping @DN6 |
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* add peft slow tests workflow * Update .github/workflows/push_tests.yml --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This was referenced Nov 28, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* add peft slow tests workflow * Update .github/workflows/push_tests.yml --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title.
Currently PEFT slow tests are not being tested on main push. This PR adds a new job in the slow tests workflow to make sure we test PEFT slow tests on main
cc @patrickvonplaten @DN6 @sayakpaul
I am also happy to push this change on a dummy branch on hf repo to test the implementation