Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Follow up of #5393 #5420

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[Examples] Follow up of #5393 #5420

merged 3 commits into from
Oct 17, 2023

Conversation

sayakpaul
Copy link
Member

@Wauplin

I have replied to your comments directly on #5393

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 17, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks @sayakpaul! I was about to do it this morning but thanks for being faster! 🚀

Looks good to me like this and agree about the run_as_future=True, I just wanted to make sure :)

@sayakpaul sayakpaul merged commit b4cbbd5 into main Oct 17, 2023
13 checks passed
@sayakpaul
Copy link
Member Author

@pcuenca just an FYI here.

@sayakpaul sayakpaul deleted the follow-up-hf-api branch October 17, 2023 06:37
@pcuenca
Copy link
Member

pcuenca commented Oct 17, 2023

Thank you! Sorry I missed the repo_id in my review.

mhetrerajat pushed a commit to mhetrerajat/diffusers that referenced this pull request Oct 23, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix: create_repo()

* Empty-Commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants