Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese docs #5478

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Japanese docs #5478

merged 9 commits into from
Oct 24, 2023

Conversation

isamu-isozaki
Copy link
Contributor

What does this PR do?

Adds Japanese documentations

Fixes #5285

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Since, it's the docs, also @stevhliu and @yiyixuxu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏

You'll also need to modify the build_documentation.yml and build_pr_documentation.yml file to include the language code for Japanese (ja) to build the docs.

docs/source/jp/_toctree.yml Outdated Show resolved Hide resolved
docs/source/jp/in_translation.md Outdated Show resolved Hide resolved
docs/source/jp/quicktour.md Outdated Show resolved Hide resolved
@isamu-isozaki
Copy link
Contributor Author

@stevhliu Thanks for the review! And should be fixed

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, just two minor ones remaining :)

.github/workflows/build_documentation.yml Outdated Show resolved Hide resolved
.github/workflows/build_pr_documentation.yml Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@isamu-isozaki
Copy link
Contributor Author

@stevhliu Forgot to say but should be done! Fixed the folder name to jp->ja too

@stevhliu
Copy link
Member

Thanks again for your contribution! 🤗

@stevhliu stevhliu merged commit b8896a1 into huggingface:main Oct 24, 2023
11 checks passed
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
* Finished _toctree.yml and index.md

* Finished installation.md

* Properly finished installation.md and almost finished quicktour

* Finished quicktour

* Finished stable diffusion doc

* Fixed _toctree.yml

* Fixed requests

* Fix country code

* Properly push
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Finished _toctree.yml and index.md

* Finished installation.md

* Properly finished installation.md and almost finished quicktour

* Finished quicktour

* Finished stable diffusion doc

* Fixed _toctree.yml

* Fixed requests

* Fix country code

* Properly push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add japanese translation for docs translation
3 participants