Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in controlnet docs #5486

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix typo in controlnet docs #5486

merged 1 commit into from
Oct 23, 2023

Conversation

MrSyee
Copy link
Contributor

@MrSyee MrSyee commented Oct 23, 2023

What does this PR do?

In ControlNet with SDXL docs, I found a typo in code example.
If you don't fix this code, you'll get an error:

Traceback (most recent call last):s: 100%|███████████████████████████████| 335M/335M [00:16<00:00, 22.4MB/s]
  File "/home/khwankim_dc/workspace/TIL/diffusers/controlnet/sdxl.py", line 49, in <module>7<00:26, 275MB/s]
    output = pipe(model.safetensors: 100%|█████████████████████████████▉| 10.2G/10.3G [00:54<00:00, 195MB/s]
  File "/home/khwankim_dc/anaconda3/envs/diffusers/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/home/khwankim_dc/anaconda3/envs/diffusers/lib/python3.10/site-packages/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl.py", line 906, in __call__
    self.check_inputs(
  File "/home/khwankim_dc/anaconda3/envs/diffusers/lib/python3.10/site-packages/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl.py", line 531, in check_inputs
    self.check_image(image, prompt, prompt_embeds)
  File "/home/khwankim_dc/anaconda3/envs/diffusers/lib/python3.10/site-packages/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl.py", line 641, in check_image
    raise ValueError(
ValueError: If image batch size is not 1, image batch size must be same as prompt batch size. image batch size: 1024, prompt batch size: 1

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 self-requested a review October 23, 2023 16:27
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patrickvonplaten
Copy link
Contributor

Great catch!

@patrickvonplaten patrickvonplaten merged commit 6e608d8 into huggingface:main Oct 23, 2023
11 checks passed
linoytsaban pushed a commit to linoytsaban/diffusers that referenced this pull request Oct 24, 2023
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants