[Core] Refactor activation and normalization layers #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
approved these changes
Oct 23, 2023
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -162,6 +162,10 @@ | |||
| title: Conceptual Guides | |||
| - sections: | |||
| - sections: | |||
| - local: api/activations | |||
There was a problem hiding this comment.
Can we move all of this under "internal classes" to make sure that users know that it's not public API and more prone to breaking changes?
There was a problem hiding this comment.
There was a problem hiding this comment.
Would it not make sense to update in a bulk PR?
Cc: @stevhliu too.
There was a problem hiding this comment.
Sure, I can update and create a new "internal classes" section in a separate PR if you'd like!
There was a problem hiding this comment.
That'd be great. So, I am merging it now then.
linoytsaban
pushed a commit
to linoytsaban/diffusers
that referenced
this pull request
Oct 24, 2023
* move out the activations. * move normalization layers. * add doc. * add doc. * fix: paths * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * style --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
kashif
pushed a commit
to kashif/diffusers
that referenced
this pull request
Nov 11, 2023
* move out the activations. * move normalization layers. * add doc. * add doc. * fix: paths * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * style --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* move out the activations. * move normalization layers. * add doc. * add doc. * fix: paths * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * style --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* move out the activations. * move normalization layers. * add doc. * add doc. * fix: paths * Apply suggestions from code review Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * style --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Slack thread (internal to Diffusers maintainers):
https://huggingface.slack.com/archives/C04DBJ0HLH1/p1697859469537249
@stevhliu docs look okay to you?