Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] in transformer_temporal Fix Bugs #5496

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[BUG] in transformer_temporal Fix Bugs #5496

merged 1 commit into from
Oct 23, 2023

Conversation

zideliu
Copy link
Contributor

@zideliu zideliu commented Oct 23, 2023

What does this PR do?

Fixes Bugs

Before submitting

Fix bugs in transformer_temporal.py line 174

        # 3. Output
        hidden_states = self.proj_out(hidden_states)
        hidden_states = (
            hidden_states[None, None, :]
            .reshape(batch_size, height, width, channel, num_frames)
            .permute(0, 3, 4, 1, 2)
            .contiguous()
        )
        hidden_states = hidden_states.reshape(batch_frames, channel, height, width)

It should be

        # 3. Output
        hidden_states = self.proj_out(hidden_states)
        hidden_states = (
            hidden_states[None, None, :]
            .reshape(batch_size, height, width, num_frames, channel)
            .permute(0, 3, 4, 1, 2)
            .contiguous()
        )
        hidden_states = hidden_states.reshape(batch_frames, channel, height, width)

But it does NOT affect the generated results

@zideliu zideliu changed the title Fix Bugs [BUG] in transformer_temporal Fix Bugs Oct 23, 2023
@DN6 DN6 self-requested a review October 23, 2023 16:59
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍🏽

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 23, 2023

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

Great catch!

@patrickvonplaten patrickvonplaten merged commit 188d864 into huggingface:main Oct 23, 2023
11 checks passed
linoytsaban pushed a commit to linoytsaban/diffusers that referenced this pull request Oct 24, 2023
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants