Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typos, improve, update at Using Diffusers' Loading & Hub page #5584

Merged
merged 16 commits into from
Nov 2, 2023
Merged

[Docs] Fix typos, improve, update at Using Diffusers' Loading & Hub page #5584

merged 16 commits into from
Nov 2, 2023

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Oct 30, 2023

What does this PR do?

Hi! Thank you for this awesome library!
I am new to open source. Firstly, I am reading the documentation. Secondly, I will read the codebase. Thirdly, I plan to make documentation and code contributions.
I would be grateful for your feedback. @stevhliu @yiyixuxu @patrickvonplaten

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 30, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to review the docs and run the code!

docs/source/en/using-diffusers/loading.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading.md Show resolved Hide resolved
docs/source/en/using-diffusers/loading_adapters.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading_adapters.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading_adapters.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/other-formats.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/push_to_hub.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/push_to_hub.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/schedulers.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/loading.md Show resolved Hide resolved
docs/source/en/using-diffusers/loading_adapters.md Outdated Show resolved Hide resolved
docs/source/en/using-diffusers/push_to_hub.md Outdated Show resolved Hide resolved
tolgacangoz and others added 5 commits November 1, 2023 08:53
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@patrickvonplaten
Copy link
Contributor

Feel free to merge once good for you @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for all the fixes!

@stevhliu stevhliu merged commit b91d5dd into huggingface:main Nov 2, 2023
11 checks passed
kashif pushed a commit to kashif/diffusers that referenced this pull request Nov 11, 2023
…age (huggingface#5584)

* Fix typos, improve, update

* Change to trending and apply some Grammarly fixes

* Grammarly fixes

* Update loading_adapters.md

* Update loading_adapters.md

* Update other-formats.md

* Update push_to_hub.md

* Update loading_adapters.md

* Update loading.md

* Update docs/source/en/using-diffusers/push_to_hub.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update schedulers.md

* Update docs/source/en/using-diffusers/loading.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/using-diffusers/loading_adapters.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update A1111 LoRA files part

* Update other-formats.md

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@tolgacangoz tolgacangoz deleted the fix-typos-9 branch November 30, 2023 07:23
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…age (huggingface#5584)

* Fix typos, improve, update

* Change to trending and apply some Grammarly fixes

* Grammarly fixes

* Update loading_adapters.md

* Update loading_adapters.md

* Update other-formats.md

* Update push_to_hub.md

* Update loading_adapters.md

* Update loading.md

* Update docs/source/en/using-diffusers/push_to_hub.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update schedulers.md

* Update docs/source/en/using-diffusers/loading.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/using-diffusers/loading_adapters.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update A1111 LoRA files part

* Update other-formats.md

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants