Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[advanced dreambooth lora sdxl] add DoRA training feature #7072

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

linoytsaban
Copy link
Collaborator

Following the integration of DoRA: Weight-Decomposed Low-Rank Adaptation into peft in: huggingface/peft#1474

This PR adds a use_dora arg to allow training a DoRA with the current advanced dreambooth script

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban linoytsaban marked this pull request as ready for review February 24, 2024 11:10
@sayakpaul
Copy link
Member

I think we should till the peft PR is merged so that we can suggest folks to install peft from the main. Also, let's propagate to the SD v1.5 advanced script?

@nbasyl
Copy link

nbasyl commented Feb 29, 2024

@linoytsaban, appreciate your effort on pushing this PR through. The DoRA PR has been successfully merged into the PEFT main branch. Since, I'm not very familiar with stable diffusion at all, it would be great if you could continue with the PR, and I can get to try DoRA on fine-tuning stable diffusion model and see if I can think of any other further improvement I can make specifically for SD finetuning.

@linoytsaban
Copy link
Collaborator Author

@sayakpaul @apolinario I added sd 1.5 and peft pr is now merged too so I can merge if ok with you :)

@sayakpaul
Copy link
Member

@sayakpaul @apolinario I added sd 1.5 and peft pr is now merged too so I can merge if ok with you :)

Let’s mention that using DoRA requires installing peft from the source. Let’s also include some notes about DoRA from your experiments to guide our users. WDYT?

Once done, LMK, I would like to do a review before finally merging.

@linoytsaban
Copy link
Collaborator Author

Added some notes about peft installation and the 2 main conclusions so far from DoRA training. WDYT?

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@linoytsaban linoytsaban merged commit 01ee097 into huggingface:main Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants