Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] [LoRA] clean up the serialization stuff. #9512

Merged
merged 4 commits into from
Sep 27, 2024
Merged

[Tests] [LoRA] clean up the serialization stuff. #9512

merged 4 commits into from
Sep 27, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

There's a lot of if/else magic involved when serializing a LoRA state dict (shout at me). This PR simplifies that.

@sayakpaul sayakpaul marked this pull request as ready for review September 24, 2024 08:24
a-r-r-o-w
a-r-r-o-w approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful, looks great!

@yiyixuxu yiyixuxu merged commit 81cf3b2 into main Sep 27, 2024
14 checks passed
@yiyixuxu yiyixuxu deleted the lora-tests-cleanup branch September 27, 2024 17:57
leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
@sayakpaul
[Tests] [LoRA] clean up the serialization stuff. (huggingface#9512)
840db3f 
* clean up the serialization stuff.

* better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayakpaul @yiyixuxu @a-r-r-o-w