Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IP Adapter Scripts to research project #9960

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Nov 19, 2024

What does this PR do?

I have moved the IP Adapter Scripts to the research project folder as mentioned, to close #7196. Please let me know if any further corrections are needed and I will make the necessary changes.

Similar to #9935 .

Before submitting

Who can review?

@sayakpaul

@sayakpaul
Copy link
Member

Can you cherry-pick the commits from #7196 and then add a commit to move them to research folder? This way, the original contributions receive the proper credits they deserve.

@pcuenca
Copy link
Member

pcuenca commented Nov 19, 2024

Can you cherry-pick the commits from #7196 and then add a commit to move them to research folder?

Agreed, or start the branch from the other PR's branch if that's easier.

@ParagEkbote
Copy link
Contributor Author

I have copied the contents from #7196 and added them to research project. Should I credit the user in the ReadME, since the branch in that repository is out-of-date.

cc: @sayakpaul

@sayakpaul
Copy link
Member

You should still be able to cherry-pick commits.

@ParagEkbote
Copy link
Contributor Author

I have cherry-picked the commits and moved files to the research project folder. Please let me know if any further corrections are needed and I will make the necessary changes.

cc: @sayakpaul

@sayakpaul
Copy link
Member

Can you run make style && make quality?

@@ -25,6 +25,7 @@
title: Working with big models
title: Tutorials
- sections:
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are git conflict markers that need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants