-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comet #443
Update comet #443
Conversation
I am not a maintainer, but I have just tested this, and it works as advertised. Thanks, @ricardorei, I hope this gets merged soon |
@lvwerra Friendly ping. Can this be merged (and maybe even with a pip upgrade)? Thanks! |
This is not working as expected. I run the example:
I expected to see a Comet score, but the output was:
This output clearly differs from what I expected. @ricardorei can you help? Thanks |
That is the expected score: |
@BramVanroy @joao-alves97 what comet version are you using? I was not able to replicate what you are referring. I tested unbabel-comet==1.1.3, 2.0.0 and 2.0.1 |
@ricardorei I think what @joao-alves97 is saying that the output is a dictionary with keys |
COMET metric was recently updated to v2.0 and the predict interface returns a single class instead of two floats.
This pull request adds a simple verification to the package version and changes the behaviour accordingly.
Also, we updated the metric README which was slightly outdated. We recently released better and improved metrics that we developed for the WMT22 Metrics shared task. For versions above 2.0 the default metric is
wmt22-comet-da
instead ofwmt20-comet-da
. This new model performs better across language pairs and domain while being more interpretable. You can check the blogpost here.