-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo love it !
I've addressed the comments and made additional improvements to make the code cleaner/more performant. Let me know what you think! I'm still trying to figure out if I can avoid the temp file creation in write mode in Having thought about it, I agree it's OK to depend on
|
@mariosasko I did not have the time to review the PR yet but about your two last points:
Yes, would definitely be good to have that. Could you create an issue for that please ?
Hmm, I see the purpose in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for working on it @mariosasko !
I have added comments, most of them been about stuff that can be leverage from huggingface_hub
. If would require huggingface_hub>=0.10.0
instead of huggingface_hub>=0.9.0
if that's fine.
Hi ! Any news on this ? @severo and I would like to use it to store datasets in Parquet format on the Hub under git references (for the datasets-server project and to showcase how to get a arbitrary slices of data) Happy to help if I can :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! looks all good :)
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Add newline to pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Thanks for making the changes :)
Add the filesystem implementation with additional tweaks (
cp_file
,rm_file
, etc.) needed for thedatasets
integration.Also, add/update supporting files to align the repo with the existing HF projects.