Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc+snippets] No more use_auth_token=True needed #326

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

julien-c
Copy link
Member

Keeping as draft until huggingface/huggingface_hub#1064 lands in a release. (and subsequently in a transformers or diffusers release if those still pin a version of huggingface_hub – not sure right now)

@julien-c julien-c changed the title No more use_auth_token=True needed [doc+snippets] No more use_auth_token=True needed Sep 23, 2022
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@julien-c
Copy link
Member Author

N.B.: This is for simplicity, passing use_auth_token is stil supported (with same potential params as before), it's just that it now defaults to True

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! 🔥

@patrickvonplaten
Copy link
Contributor

Nice! @patil-suraj @pcuenca @anton-l let's make sure we update the Diffusers docs here as well

@julien-c
Copy link
Member Author

Making note to merge this around end-of-year!

@julien-c julien-c marked this pull request as ready for review December 20, 2022 17:47
@julien-c
Copy link
Member Author

it's around end-of-year, so i'm merging this!

@julien-c julien-c merged commit 7f98a58 into main Dec 20, 2022
@julien-c julien-c deleted the no-more-use_auth_token branch December 20, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants