Handle refs/convert/parquet
and PR revision correctly in hffs
#1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1710 by processing
refs/convert/parquet
andrefs/pr/(\d)+
as special revisions when resolving a path. Also make sure that theunresolve
counterpart works the same. Also added some tests for it.Use case from @Hakimovich99 now works properly without having to url-encode the revision. This time I tested with jamescalam/llama-2-arxiv-papers-chunked dataset which doesn't have parquet files on
main
revision:This should be a small QOL improvements for datasets users while not degrading the experience for others.