-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_repo_likers method to HfApi #1715
Conversation
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean and complete PR, thanks @issamarabi! I added 2 minor comments but overall looks good. 🎉
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @issamarabi thanks for making the changes! I re-reviewed and tested it locally. I hope you don't mind, I pushed a commit to your branch to:
- apply formatting (run
make style
) - add
User
object to the docs (I forgot to mention it) - add
User
andlist_repo_likers
at root level. This makes them usable without intanciatingHfApi
yourself - fix an attribute name
I think we are good to merge now. Great addition!
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
==========================================
- Coverage 82.42% 82.01% -0.42%
==========================================
Files 62 62
Lines 7244 7260 +16
==========================================
- Hits 5971 5954 -17
- Misses 1273 1306 +33
☔ View full report in Codecov by Sentry. |
awesome job @issamarabi 🔥 |
Summary
This PR introduces the
list_repo_likers
method to theHfApi
class, allowing users to retrieve a list of likers for a given model repository on the Hugging Face Hub.Changes
list_repo_likers
method inHfApi
.User
to represent users who liked a repo.Motivation