Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move executorch export to optimum-executorch #1

Merged
merged 14 commits into from
Jan 24, 2025
Merged

Move executorch export to optimum-executorch #1

merged 14 commits into from
Jan 24, 2025

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Jan 21, 2025

Following huggingface/optimum#2090 (comment)

ExecuTorch export (introduced in huggingface/optimum#2090) is moved in optimum-executorch see huggingface/optimum#2165

@echarlaix echarlaix marked this pull request as ready for review January 23, 2025 09:36
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for handling this

setup.py Show resolved Hide resolved
@guangy10
Copy link
Contributor

@echarlaix do you mind explaining the motivation of moving to optimum-executorch? I remember you briefly mentioned that during out meetup at HF Paris office but can't recall the details. I want to make sure such a move will not potentially decrease the visibility executorch to HF users. Thanks!

@echarlaix
Copy link
Collaborator Author

@guangy10 we are planning to keep in the optimum repo only things which are common to all subpackages and to move everything else in specific repos (the same will happen for anything onnx related for example). I understand your point concerning visibility, something we can do to make sure this is not the case is to clearly redirect users to this repo in the optimum and transformers documentation, what do you think ?

@echarlaix echarlaix merged commit 6cc4619 into main Jan 24, 2025
22 checks passed
@guangy10
Copy link
Contributor

guangy10 commented Jan 24, 2025

@guangy10 we are planning to keep in the optimum repo only things which are common to all subpackages and to move everything else in specific repos (the same will happen for anything onnx related for example). I understand your point concerning visibility, something we can do to make sure this is not the case is to clearly redirect users to this repo in the optimum and transformers documentation, what do you think ?

Thanks for the clarification. With such move, is it possible for us to get more fine-grained metrics/stats? For example, compare DAU/downloads/checkout across different optimum supported backends, e.g. onnx, executorch, tflite, etc. assuming onnx and tflite are going to optimum-onnx, and optimum-tflite.
Can we also track per model inference across different backends? Maybe other metrics, do you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants