revert rotary embedding patching for recovering gpu accuracy #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AlexKoff88
approved these changes
Jul 31, 2024
echarlaix
approved these changes
Jul 31, 2024
|
Before merging can you also revert the modifications from the expected int8 ops in the tests #783 to fix the tests ? |
eaidova
force-pushed
the
ea/remove_bf16_rotary_emb_patching
branch
from
017fba0 to
5d32229
Compare
3 tasks
IlyasMoutawwakil
pushed a commit
that referenced
this pull request
Aug 6, 2024
* revert rotary embedding patching for recovering gpu accuracy * revert tests * Update test_exporters_cli.py
IlyasMoutawwakil
pushed a commit
that referenced
this pull request
Aug 6, 2024
* revert rotary embedding patching for recovering gpu accuracy * revert tests * Update test_exporters_cli.py
IlyasMoutawwakil
pushed a commit
that referenced
this pull request
Aug 6, 2024
* revert rotary embedding patching for recovering gpu accuracy * revert tests * Update test_exporters_cli.py
IlyasMoutawwakil
pushed a commit
that referenced
this pull request
Aug 6, 2024
* revert rotary embedding patching for recovering gpu accuracy * revert tests * Update test_exporters_cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this is temporal solution for unblocking model running on GPU with openvino<=2024.3, bf16 accuracy will be fixed later, when openvino runtime will be ready handle it.