fix attention mask for glm4 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@echarlaix, @IlyasMoutawwakil please take a look |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
force-pushed
the
ea/fix_attention_mask_glm4
branch
from
8dbe93c to
afd2b6d
Compare
IlyasMoutawwakil
approved these changes
Aug 30, 2024
eaidova
force-pushed
the
ea/fix_attention_mask_glm4
branch
from
afd2b6d to
efb5d13
Compare
echarlaix
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix attention mask transition from bool to fp32 in glm4 according scaled_dot_product specification
Fixes # (issue)
Before submitting