Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Inference APIs to Neuron 2.13 #206

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Bump Inference APIs to Neuron 2.13 #206

merged 6 commits into from
Aug 30, 2023

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented Aug 29, 2023

  • Unblock VAE encoder
  • Remove optimized cross-attention score workaround
  • Unblock dynamic batching test
  • Update documentation

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@JingyaHuang JingyaHuang marked this pull request as ready for review August 29, 2023 16:56
Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/source/guides/models.mdx Outdated Show resolved Hide resolved
@@ -226,6 +231,7 @@ optimum-cli export neuron --model stabilityai/stable-diffusion-2-1-base \
--batch_size 1 \
--height 512 `# height in pixels of generated image, eg. 512, 768` \
--width 512 `# width in pixels of generated image, eg. 512, 768` \
--num_image_per_prompt 4 `# number of images to generate per prompt, defaults to 1` \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed with dynamic batching support now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we turn on dynamic batching, we can input any batch size / number images per prompt, but by default the dynamic batch size is turned off, so we can keep the snippet this way I think.

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingyaHuang JingyaHuang merged commit b93c706 into main Aug 30, 2023
11 of 13 checks passed
@JingyaHuang JingyaHuang deleted the bump-to-2.13 branch August 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants