Initial support for Pipeline Parallelism #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
dacorvo
approved these changes
Jan 22, 2024
JingyaHuang
reviewed
Jan 22, 2024
| @@ -177,6 +195,15 @@ def main(): | |||
| else: | |||
| model_args, data_args, training_args = parser.parse_args_into_dataclasses() | |||
|
|
|||
| if model_args.use_auth_token is not None: | |||
| warnings.warn( | |||
| "The `use_auth_token` argument is deprecated and will be removed in v4.34. Please use `token` instead.", | |||
There was a problem hiding this comment.
which package? transformers?
There was a problem hiding this comment.
Yes. But I'm not in favor of adding that. These files are updated automatically by cloning the examples from Transformers. This is a bad side effect but I think that's ok.
|
I addressed the comments. @dacorvo @JingyaHuang wdyt? |
JingyaHuang
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Pipeline Parallelism on a single node for the Llama architecture.
Multi-node training and other possible relevant architectures will be added in later PRs.
Training
PP works
Variants
Only tested via tests here (it will be tested more in the PR for multi-node training).
Checkpointing
Tests
tests/distributed/test_model_parallelization.pytests/test_examples.pytests/distributed/test_common.pyOther