fix(decoder): remove call to beta serialization api #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
requested review from
philschmid,
michaelbenayoun,
mfuntowicz and
JingyaHuang
JingyaHuang
approved these changes
Dec 22, 2023
| @@ -246,7 +246,7 @@ def _save_pretrained(self, save_directory: Union[str, Path]): | |||
|
|
|||
| if src_compiled_path is None: | |||
| # The compiled model has never been serialized: do it now | |||
| self.model._save_compiled_artifacts(dst_compiled_path) | |||
| self.model.save(dst_compiled_path) | |||
There was a problem hiding this comment.
Do all these stable APIs also exist in 2.15.2? Otherwise do we need to bump the transformers-neuronx's version in the setup?
There was a problem hiding this comment.
No they are already there (introduced in 2.15.0). I had not seen them, but the doc had indeed been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of pull-request #387, also removing the call to the experimental serialization API when saving the model.