-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre Neuron Inf Cache system]Support neff/weights decoupling #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
JingyaHuang
changed the title
[Neuron Inf Cache system]Support neff/weights decoupling + setup initial caching for inference
[Neuron Inf Cache system]Support neff/weights decoupling
Jan 24, 2024
JingyaHuang
changed the title
[Neuron Inf Cache system]Support neff/weights decoupling
[Pre Neuron Inf Cache system]Support neff/weights decoupling
Jan 25, 2024
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
dacorvo
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you have a typo in your tests.
Co-authored-by: David Corvoysier <david@huggingface.co>
dacorvo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
inline_weights_to_neff
argument, we are now able to decouple the weights and neff graph during the compilation. It means that we can set up a caching system for reusing shared compiled neff graphs and load with weights from different checkpoints during the inference. This could largely save the compilation time which could take up to hours.inline_weights_to_neff
in Neuron exporter[Next step]
Initial caching for inference of encoder models
optimum-cli
for creating public/private cache)from_pretrained
when export=True and cache exist.