Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to optimum 1.17 - Adapt to optimum exporter refactoring #414

Merged
merged 19 commits into from
Feb 19, 2024

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented Jan 17, 2024

[Optimum 1.17.0 release scheduled today at 10 AM CET]

This is a standby PR for supporting the refactoring of the task manager in Optimum main repo.
Relaunch CI before getting it merge once we have huggingface/optimum#1647 included in a stable optimum release!

@JingyaHuang JingyaHuang changed the title [WIP] Adapt to optimum exporter refactoring [DON'T MERGE IT] Adapt to optimum exporter refactoring Feb 1, 2024
@JingyaHuang JingyaHuang changed the title [DON'T MERGE IT] Adapt to optimum exporter refactoring Bump to optimum 1.17 - Adapt to optimum exporter refactoring Feb 16, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

dacorvo and others added 3 commits February 16, 2024 09:48
This runs export and pipelines tests in dedicated pipelines with
stricter path filters to avoid running them on every change.
This runs export and pipelines tests in dedicated pipelines with
stricter path filters to avoid running them on every change.
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we will be able to remove the pytest limitation once transformers fixes the issue, right ?

@dacorvo dacorvo merged commit 460d226 into main Feb 19, 2024
14 checks passed
@dacorvo dacorvo deleted the adapt-to-optimum-exporter-refectoring branch February 19, 2024 07:55
@JingyaHuang
Copy link
Collaborator Author

@dacorvo Once the newer pytest is compatible with a transformers release, and optimum-neuron is able to bump to that transformers version, we can remove the pytest pinned version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants