Allow exporting decoder models using optimum-cli #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
force-pushed
the
cli_export_decoders
branch
from
a00d425
to
0e705d2
Compare
philschmid
approved these changes
Jan 24, 2024
I thought I did add one, but I might have dreamed it, or I lost it in my rebase ... |
Done. |
michaelbenayoun
approved these changes
Jan 24, 2024
| # If the sequence_length was not specified, deduce it from the model configuration | ||
| if sequence_length is None: | ||
| # Note: for older models, max_position_embeddings is an alias for n_positions | ||
| sequence_length = config.max_position_embeddings | ||
| if num_cores is None: | ||
| # Use all available cores | ||
| num_cores = len(os.listdir("/sys/class/neuron_device/")) * 2 |
There was a problem hiding this comment.
This will fail if the directory does not exist. Are we sure that this code can only be executed on a machine that has neuron devices?
There was a problem hiding this comment.
I added a check on top of the function. It is not possible to instantiate the transformers-neuronx model otherwise.
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
dacorvo
force-pushed
the
cli_export_decoders
branch
from
70c4da9
to
c4fdaec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long awaited feature ... it is now possible to export decoder models just like any other models using the optimum-cli.