Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama2 inference benchmark under a new "benchmarks" section #435

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Jan 23, 2024

This is basically the content of the benchmark paragraph in the corresponding blog post.

I have also added the scripts to run the benchmark and generate the images.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to have a separate section for benchmarks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the instance type/number of neuron cores in the title?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no guarantee that all models are using the same number of cores. It is saved in the JSON results file for each model though, so eventually we could use it.

docs/source/_toctree.yml Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
docs/source/benchmarks/inferentia-llama2.mdx Outdated Show resolved Hide resolved
Co-authored-by: Philipp Schmid <32632186+philschmid@users.noreply.github.com>
@dacorvo dacorvo merged commit 2709183 into main Jan 24, 2024
1 check passed
@dacorvo dacorvo deleted the benchmark branch January 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants