-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neuronx cache registry #442
Conversation
c2114a6
to
13f5718
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
bf9d7f6
to
a3d7804
Compare
preprocess_logits_for_metrics=( | ||
preprocess_logits_for_metrics if training_args.do_eval and not is_torch_tpu_available() else None | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just formatting?
Anyways those example are automatically generated from the Transformers library so this change will be overriden when we synchronize with the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't apply them, then the check-code-quality fails. I could exclude the examples from it though ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I just wanted to check if the change was only about styling. After reading the rest of the PR I understood it was automatic reformatting.
Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
This extends the neuronx caching for decoder models to store the cached neuron configurations under a specific
registry
folder for eachneuronxcc
compiler version.This also adds a
get_hub_cached_entries
helper and CLI command to lookup cached configurations for a specificmodel_id
.The output looks like this: