Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address several NeuronModelForCausalLM and TGI issues #454

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Address several NeuronModelForCausalLM and TGI issues #454

merged 9 commits into from
Jan 31, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Jan 31, 2024 •
edited
Loading

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dacorvo dacorvo marked this pull request as ready for review January 31, 2024 12:32
JingyaHuang
JingyaHuang approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some nits, thanks for the fixes!

optimum/neuron/generation/token_selector.py Outdated Show resolved Hide resolved
optimum/neuron/modeling.py Outdated Show resolved Hide resolved
optimum/neuron/modeling_decoder.py Show resolved Hide resolved
@dacorvo dacorvo requested a review from JingyaHuang January 31, 2024 14:15
michaelbenayoun
michaelbenayoun approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these issues!

@dacorvo dacorvo merged commit eb2a93f into main Jan 31, 2024
7 checks passed
@dacorvo dacorvo deleted the various_fixes branch January 31, 2024 16:48
@dacorvo dacorvo changed the title Address several NeuronModelForCausalLM and TGI fixes issues Address several NeuronModelForCausalLM and TGI issues Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbenayoun michaelbenayoun michaelbenayoun approved these changes

@JingyaHuang JingyaHuang JingyaHuang approved these changes

@philschmid philschmid Awaiting requested review from philschmid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dacorvo @HuggingFaceDocBuilderDev @michaelbenayoun @JingyaHuang