Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new cache system for training #472

Merged
merged 20 commits into from
Feb 16, 2024
Merged

Integrate new cache system for training #472

merged 20 commits into from
Feb 16, 2024

Conversation

michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Feb 9, 2024

What does this PR do?

Integrate the native cache system to training.

To do in following PRs:

  • Update the documentation
  • Remove former cache util code that is not useful anymore, this includes the functions and the tests
  • Unify optimum/neuron/utils/cache_utils.py and optimum/neuron/utils/hub_neuronx_cache.py.

cc @5cp

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelbenayoun michaelbenayoun marked this pull request as ready for review February 9, 2024 17:57
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment: if you could move the check for parallel compile in the parallel compile related code that would be awesome.
Otherwise LGTM.

optimum/neuron/utils/hub_neuronx_cache.py Show resolved Hide resolved
optimum/neuron/utils/hub_neuronx_cache.py Outdated Show resolved Hide resolved
optimum/neuron/utils/hub_neuronx_cache.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull-request: a brand new training cache !

@dacorvo dacorvo merged commit d319856 into main Feb 16, 2024
10 of 11 checks passed
@dacorvo dacorvo deleted the cache_training branch February 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants