Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): omit irrelevant config parameters in lookup #494

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Feb 21, 2024

What does this PR do?

It adds a white list of parameters to omit when comparing config.json in cache lookups.

The current white-list is:

  • _name_or_path,
  • transformers_version,
  • eos_token_id,
  • bos_token_id,
  • pad_token_id.

@dacorvo dacorvo marked this pull request as ready for review February 21, 2024 09:22
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, makes it easy to update too

@dacorvo dacorvo merged commit aa56b10 into main Feb 22, 2024
11 checks passed
@dacorvo dacorvo deleted the improve_lookup branch February 22, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants