Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip weight load during parallel compile #524

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Since the real weights are not needed during precompilation, we can skip weight initialization / loading.

@michaelbenayoun michaelbenayoun marked this pull request as ready for review March 21, 2024 13:13
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks (just saw a typo in base.py line 677, but keep it for another pr).

@michaelbenayoun michaelbenayoun merged commit 253f94f into main Mar 21, 2024
9 of 12 checks passed
@michaelbenayoun michaelbenayoun deleted the skip_weight_load_during_parallel_compile branch March 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants