Fix GQA permutation computation and sequential weight initialization / loading when doing TP #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
michaelbenayoun
changed the title
michaelbenayoun
commented
Mar 27, 2024
There was a problem hiding this comment.
Will restore this change before merging.
JingyaHuang
approved these changes
Mar 28, 2024
| local_rank = xm.get_local_ordinal() | ||
| if num_ranks_per_loading_step < 0: | ||
| num_ranks_per_loading_step = get_local_world_size() | ||
| for worker in range(math.ceil(get_local_world_size() / num_ranks_per_loading_step)): |
There was a problem hiding this comment.
So there will be two workers (0, 1) if get_local_world_size() / num_ranks_per_loading_step > 1 and < 2?
There was a problem hiding this comment.
I can set num_ranks_per_loading_step = min(num_ranks_per_loading_step, get_local_world_size()) as a safety measure.
|
Ran the distributed tests locally and they pass. It's just a flaky test that needs to be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
indicies -> indices