upgrade optimum and then install optimum-neuron #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacorvo
approved these changes
Mar 28, 2024
|
Let's improve tests to make sure it really works. |
It doesn't work, when I try |
|
My recent commits shall solve the installation issue, could you review it? Tested with |
philschmid
reviewed
Apr 9, 2024
| "evaluate==0.4.1" \ | ||
| "requests==2.31.0" \ | ||
| "notebook==7.0.6" \ | ||
| "markupsafe==2.1.1" \ | ||
| "jinja2==3.1.2" \ | ||
| "attrs==23.1.0" | ||
|
|
||
| # Temporary fix for the issue: https://github.com/huggingface/optimum-neuron/issues/142 | ||
| pip install -U optimum |
There was a problem hiding this comment.
I think from now on optimum-neuron will be always compatible with the latest optimum since the installation of the latest optimum-neuron via optimum's neuronx extra won't work otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes issue #532 and applies the fix suggested by @dacorvo here: #142 (comment)
Fixes # (issue)
Before submitting