Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in get_available_cores within container #546

Merged
merged 4 commits into from
Apr 2, 2024
Merged

fix: bug in get_available_cores within container #546

merged 4 commits into from
Apr 2, 2024

Conversation

oOraph
Copy link
Contributor

@oOraph oOraph commented Apr 2, 2024

fixes #544

@oOraph
fix: bug in get_available_cores within container
5279b7b 
fixes huggingface#544

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@oOraph
fix: functools.cache not available before python 3.9
9c4d6ac 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph
reformat
dacc23c 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph
reformat
50aa81f 
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
@oOraph
Copy link
Contributor Author

oOraph commented Apr 2, 2024 •
edited
Loading

@dacorvo, @JingyaHuang some tests fail but it does not look like it's related to any change made in this pr: it looks like some missing token or auth issue (at least for both tests "Optimum Neuron - Common tests on Trainium" and "Optimum neuron / Test INF1 inference / Run INF1")

can you confirm ?

@dacorvo
Copy link
Collaborator

dacorvo commented Apr 2, 2024

@dacorvo, @JingyaHuang some tests fail but it does not look like it's related to any change made in this pr: it looks like some missing token or auth issue (at least for both tests "Optimum Neuron - Common tests on Trainium" and "Optimum neuron / Test INF1 inference / Run INF1")

can you confirm ?

Yes, builds from forks cannot use the CI token, leading to unauthorized access errors.

dacorvo
dacorvo approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@dacorvo dacorvo merged commit bb66802 into huggingface:main Apr 2, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacorvo dacorvo dacorvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimum.neuron.modeling_decoder.get_available_cores returns a wrong result
3 participants
@oOraph @HuggingFaceDocBuilderDev @dacorvo