Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache utils related cleanup #553

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Cache utils related cleanup #553

merged 5 commits into from
Apr 8, 2024

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Removes obsolete code related to the previous cache system for training.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelbenayoun michaelbenayoun marked this pull request as ready for review April 8, 2024 08:07
Copy link
Collaborator

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the housekeeping (˵ •̀ ᴗ - ˵ ) ✧

@michaelbenayoun michaelbenayoun requested review from JingyaHuang and dacorvo and removed request for dacorvo April 8, 2024 08:23
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@dacorvo
Copy link
Collaborator

dacorvo commented Apr 8, 2024

Let's merge this after the release, shall we ?

@michaelbenayoun
Copy link
Member Author

Merging before the release since we need the fix to be able to fetch from a remote cache repo.

@michaelbenayoun michaelbenayoun merged commit 1f049e1 into main Apr 8, 2024
10 of 11 checks passed
@michaelbenayoun michaelbenayoun deleted the cleanup branch April 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants