Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable weights / neff separation of SDXL's UNET for neuron sdk 2.18 #554

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

JingyaHuang
Copy link
Collaborator

What does this PR do?

Issue reported here: aws-neuron/aws-neuron-sdk#859

Force inline_weights_to_neff=True for sdxl's unet for now to be able to bump optimum-neuron to neuron SDK 2.18, to remove after it's patched by the Annapurna team.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@JingyaHuang JingyaHuang changed the title Disable weights / neff separation for neuron sdk 2.18 Disable weights / neff separation of SDXL's UNET for neuron sdk 2.18 Apr 5, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@JingyaHuang JingyaHuang merged commit e3bc576 into main Apr 5, 2024
13 checks passed
@JingyaHuang JingyaHuang deleted the disable-sdxl-inline branch April 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants