Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup obsolete code #555

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Cleanup obsolete code #555

merged 11 commits into from
Apr 9, 2024

Conversation

michaelbenayoun
Copy link
Member

@michaelbenayoun michaelbenayoun commented Apr 5, 2024

What does this PR do?

As per title.

Remaining tasks:

  • See what can be refactored / moved in utils/training_utils.py and utils/misc.py
  • Remove FSDP related code

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@michaelbenayoun michaelbenayoun marked this pull request as ready for review April 9, 2024 12:35
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks !

@michaelbenayoun michaelbenayoun merged commit b300db0 into main Apr 9, 2024
8 of 12 checks passed
@michaelbenayoun michaelbenayoun deleted the cleanup_obsolete_code branch April 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants