Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tgi env wrapper for neuron #589

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

oOraph
Copy link
Contributor

@oOraph oOraph commented May 3, 2024

when several compatible entries are found, take the one that uses the most cores and then has the biggest batch size

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philschmid did a similar pull-request on moon-landing for the snippets.
His code is much simpler, can you check it out ?
https://github.com/huggingface/moon-landing-aws-integrations/pull/10

when several compatible entries are found, take the one that uses the most cores
and then has the biggest batch size

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@dacorvo dacorvo merged commit f24e60d into huggingface:main May 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants