Fix diffusion caching #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fixes huggingface#593 Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
oOraph
force-pushed
the
dev/fix_diffusion_cache
branch
from
999bec6
to
c988fb7
Compare
| @@ -698,6 +699,7 @@ def _export( | |||
| save_dir = TemporaryDirectory() | |||
| save_dir_path = Path(save_dir.name) | |||
| # 1. Fetch all model configs | |||
| input_shapes_copy = copy.deepcopy(input_shapes) | |||
There was a problem hiding this comment.
nit: maybe just shadow input_shapes and do:
Suggested change
| input_shapes_copy = copy.deepcopy(input_shapes) | |
| input_shapes = copy.deepcopy(input_shapes) |
There was a problem hiding this comment.
this will shadow it but before it's actually updated in the call below, so the problem won't be fixed, no ?
There was a problem hiding this comment.
Ok, no worries then, let's keep it like that.
michaelbenayoun
approved these changes
May 14, 2024
There was a problem hiding this comment.
Gently pinging @dacorvo since INF2 test do not pass. It seems to be unrelated but double checking.
|
I don't know how the CI was triggered, but it does not seem to have the correct token, which explains the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #593