Patch attention score far off issue for sd 1.5 #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #607
For the SD 1.5 checkpoint, we used to apply optimized attention score (replacing
torch.badbmm
bytorch.bmm
, since we don't have attention_mask as input, it could save some compute). But oddly, the trick works theoretically and works for other SD models, e.g. SD2, and SDXL, but not for SD 1.5...We will apply in this PR a less optimized
get_attention_scores
for SD1.5 (almost the original one in diffusers) until we find the root cause.Before submitting