Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch attention score far off issue for sd 1.5 #611

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

JingyaHuang
Copy link
Collaborator

@JingyaHuang JingyaHuang commented May 28, 2024

What does this PR do?

Fixes #607

For the SD 1.5 checkpoint, we used to apply optimized attention score (replacing torch.badbmm by torch.bmm, since we don't have attention_mask as input, it could save some compute). But oddly, the trick works theoretically and works for other SD models, e.g. SD2, and SDXL, but not for SD 1.5...

We will apply in this PR a less optimized get_attention_scores for SD1.5 (almost the original one in diffusers) until we find the root cause.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@JingyaHuang JingyaHuang merged commit 2dcdf38 into main May 29, 2024
13 checks passed
@JingyaHuang JingyaHuang deleted the fix-sd15-perf branch May 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The quality of generated image using NeuronStableDiffusionPipeline is very poor
4 participants