Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending TGI benchmarking and documentation #621

Merged
merged 16 commits into from
Jun 5, 2024

Conversation

jimburtoft
Copy link
Contributor

This PR extends the Readme for TGI benchmarking and adds additional benchmarks.

It includes:
-A note about downloading and tagging TGI image if you aren't building it locally(discussed with @dacorvo in #605 )
-Llama3-70B example on both Inferentia and Trainium.
-instructions on how to compile models not available in the hub (e.g. 32 core Llama3-70B)
-A run_all.sh script that will generate benchmarks for different concurrencies. (if there is an easier way to do this, like passing a list into the benchmark.sh script, I don't know how).
-Does not change the existing examples in case you are using them for any TGI tests.
-Adds some batch size=one metrics

Before submitting

  • [X ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X ] Did you make sure to update the documentation with your changes?
  • [N/A ] Did you write any new necessary tests?

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this pull-request ! I have made a few comments.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Co-authored-by: David Corvoysier <david.corvoysier@gmail.com>
HF_SEQUENCE_LENGTH settings from .env and
docker compose.
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@dacorvo dacorvo merged commit af0506f into huggingface:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants