Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bf16 to true when needed #635

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Set bf16 to true when needed #635

merged 2 commits into from
Jun 17, 2024

Conversation

michaelbenayoun
Copy link
Member

What does this PR do?

Sets the bf16 flag when its relevant.

@michaelbenayoun michaelbenayoun marked this pull request as ready for review June 14, 2024 15:14
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small nit.

optimum/neuron/training_args.py Outdated Show resolved Hide resolved
Co-authored-by: David Corvoysier <david@huggingface.co>
@michaelbenayoun michaelbenayoun merged commit 047c65e into main Jun 17, 2024
10 of 12 checks passed
@michaelbenayoun michaelbenayoun deleted the set_bf16_to_true branch June 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants