Refactor decoder tests #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
michaelbenayoun
approved these changes
Jun 26, 2024
JingyaHuang
approved these changes
Jun 26, 2024
| neuron_push_decoder_id = neuron_push_model_id(model_id) | ||
| _test_push_to_hub(model, tmpdir, neuron_push_decoder_id, ignore_patterns) | ||
|
|
||
|
|
||
| @is_inferentia_test | ||
| @requires_neuronx | ||
| def test_seq2seq_model_from_hub(): |
There was a problem hiding this comment.
Ok, I shall do the same for seq2seq tests then.
There was a problem hiding this comment.
Yes, but I was wondering if you wanted to keep these anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This regroups all decoder tests under the same directory, and fixes a long standing bug preventing models exported from a local directory to be saved.
This also adds a small workaround to a TGI docker build issue (fixed in next version of TGI).